Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the shorthand for test all cases. #2840

Merged
merged 5 commits into from
Dec 25, 2021

Conversation

Shylock-Hg
Copy link
Contributor

No description provided.

@Shylock-Hg Shylock-Hg added the ready-for-testing PR: ready for the CI test label Sep 10, 2021
@Shylock-Hg Shylock-Hg requested review from a team September 10, 2021 03:44
@Sophie-Xie Sophie-Xie requested review from CPWstatic and nevermore3 and removed request for a team September 16, 2021 05:06
@@ -94,6 +94,8 @@ slow-query: currdir
tck: jobs slow-query
$(test_j) tck/steps/test_tck.py

test-all: test tck
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Currently using make tck to start test cases. why support another command?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just for typing less.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fine it's an alias

@codecov-commenter
Copy link

Codecov Report

Merging #2840 (b59278f) into master (d6f83f3) will increase coverage by 0.05%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2840      +/-   ##
==========================================
+ Coverage   85.24%   85.29%   +0.05%     
==========================================
  Files        1278     1278              
  Lines      119200   119202       +2     
==========================================
+ Hits       101608   101673      +65     
+ Misses      17592    17529      -63     
Impacted Files Coverage Δ
src/common/memory/MemoryUtils.cpp 93.33% <100.00%> (+0.65%) ⬆️
...c/meta/processors/parts/GetPartsAllocProcessor.cpp 83.05% <0.00%> (-8.48%) ⬇️
src/common/thrift/ThriftClientManager-inl.h 82.97% <0.00%> (-6.39%) ⬇️
src/graph/planner/Planner.cpp 75.00% <0.00%> (-5.00%) ⬇️
src/common/datatypes/HostAddrOps-inl.h 75.67% <0.00%> (-2.71%) ⬇️
src/common/expression/LogicalExpression.cpp 91.66% <0.00%> (-1.73%) ⬇️
src/graph/session/GraphSessionManager.cpp 79.09% <0.00%> (-1.70%) ⬇️
src/kvstore/wal/test/AtomicLogBufferTest.cpp 94.73% <0.00%> (-1.06%) ⬇️
...eta/processors/session/SessionManagerProcessor.cpp 78.06% <0.00%> (-0.65%) ⬇️
src/meta/processors/BaseProcessor-inl.h 86.80% <0.00%> (-0.59%) ⬇️
... and 27 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e33924f...b59278f. Read the comment docs.

@yixinglu yixinglu merged commit 4f827ea into vesoft-inc:master Dec 25, 2021
@Shylock-Hg Shylock-Hg deleted the util/shorthand-test-all branch February 9, 2022 07:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-for-testing PR: ready for the CI test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants